Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new page for brand guidelines #532

Closed
mcturco opened this issue Jan 5, 2022 · 17 comments
Closed

Add new page for brand guidelines #532

mcturco opened this issue Jan 5, 2022 · 17 comments

Comments

@mcturco
Copy link
Member

mcturco commented Jan 5, 2022

Reason/Context

Wondering if someone can help me duplicate the docs layout to a new page of the website perhaps with the slug /brand-guidelines/. I can then build out the pages that we need for this new area in MDX. Just unsure of how everything is included in the index and would rather the help of someone who knows what they are doing 😄

Thanks in advance!

@yashsehgal
Copy link

Hey @mcturco
I would like to help you with this issue.

What I have understood with the description is we need to create a new section for Brand Guidelines with the slug /brand-guidelines and then inside that there will be multiple sections (files with MD/MDX syntax), right?

If that's the exact thing we want then I can start working on this. If not, then what other things to add?

@mcturco
Copy link
Member Author

mcturco commented Jan 7, 2022

Hi @yashsehgal

Awesome, I would very much appreciate your help with this!

Yes, so basically all I am asking is for someone to set up the /brand-guidelines/ Layout and I can pick it up from there and add in any additional MDX pages/components that I need to build out those pages.

Does that make sense?

@yashsehgal
Copy link

Hi @yashsehgal

Awesome, I would very much appreciate your help with this!

Yes, so basically all I am asking is for someone to set up the /brand-guidelines/ Layout and I can pick it up from there and add in any additional MDX pages/components that I need to build out those pages.

Does that make sense?

Oh great, Now it's clear. I will raise a PR.

@yashsehgal
Copy link

I have added a page with route like
image

And this is how the content is being rendered on the website, but I think the styles are not working here.
image

@mcturco
Copy link
Member Author

mcturco commented Jan 10, 2022

@yashsehgal FYI
I was having problems too, but @magicmatatjahu hopped on a call with me and showed me how to create new post pages. It's pretty simple once you know where to make the changes!! See my draft PR

Thank you for offering your help! 😄 If you would like to help me build out components for these MDX pages that would be AWESOME. I can mock them up in Figma if that works?

@yashsehgal
Copy link

@yashsehgal FYI I was having problems too, but @magicmatatjahu hopped on a call with me and showed me how to create new post pages. It's pretty simple once you know where to make the changes!! See my draft PR

Thank you for offering your help! 😄 If you would like to help me build out components for these MDX pages that would be AWESOME. I can mock them up in Figma if that works?

Yeah sure, That would be great to be involved in the process. I will surely help you with the components designing part.

@magicmatatjahu
Copy link
Member

Of course this is topic handled by @mcturco but we should consider where we should put new page in the navigation. It should't be /docs because even it is a guide, it's not a docs for spec. /community in my opinion isn't relevant, because brand is related to identity of project, not to community itself, so maybe new category under /resources? We should also add there list of articles written by @Barbanio and other people that don't publish them in our blog. What do you think?

cc @fmvilas @derberg @Barbanio @alequetzalli

@fmvilas
Copy link
Member

fmvilas commented Jan 11, 2022

I'd put it on the footer, that's where you usually find these things. Ah, and would rename the page to brand so the URL is asyncapi.com/brand.

@Barbanio
Copy link
Contributor

@magicmatatjahu I think it's a very good idea. And I agree with @fmvilas that maybe the best place to put it is on the footer.

@mcturco mcturco moved this to Website Design in Design [old] Jan 13, 2022
@quetzalliwrites
Copy link
Member

@magicmatatjahu @mcturco yeah, I agree w/ Fran's idea. I think we should have a hyperlink in the footer for Brand or Brand Guidelines and then the URL to be /brand. 😀👍🏽👍🏽

@mcturco mcturco moved this from Complete to On Hold in Design [old] May 9, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label May 16, 2022
@magicmatatjahu
Copy link
Member

Still needed.

@mcturco
Copy link
Member Author

mcturco commented May 16, 2022

@magicmatatjahu I actually have an open PR here to add brand guidelines docs to the brand repo: asyncapi/brand#50

Do we think that the brand guidelines pages on the website are still needed if we have them in github? Or maybe we can just grab the content from the github pages and add them to the website as well?

@magicmatatjahu
Copy link
Member

@mcturco Hi! I see you've done a lot of work on the given PR :D We can do it like this, the brand repo would be a source of information for our design/brand and in the future we can render those sources on our site (like /docs). Currently we can just add a link in the footer of website to the brand repository. What do you think about this?

@mcturco
Copy link
Member Author

mcturco commented May 17, 2022

@magicmatatjahu yeah, that sounds good to me!

@magicmatatjahu
Copy link
Member

Ok, so this issue will be still relevant.

@mcturco
Copy link
Member Author

mcturco commented Aug 31, 2022

I believe this issue is resolved as per #808 😄

@mcturco mcturco closed this as completed Aug 31, 2022
Repository owner moved this from On Hold to Complete in Design [old] Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants