-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new page for brand guidelines #532
Comments
Hey @mcturco What I have understood with the description is we need to create a new section for Brand Guidelines with the slug If that's the exact thing we want then I can start working on this. If not, then what other things to add? |
Hi @yashsehgal Awesome, I would very much appreciate your help with this! Yes, so basically all I am asking is for someone to set up the Does that make sense? |
Oh great, Now it's clear. I will raise a PR. |
@yashsehgal FYI Thank you for offering your help! 😄 If you would like to help me build out components for these MDX pages that would be AWESOME. I can mock them up in Figma if that works? |
Yeah sure, That would be great to be involved in the process. I will surely help you with the components designing part. |
Of course this is topic handled by @mcturco but we should consider where we should put new page in the navigation. It should't be |
I'd put it on the footer, that's where you usually find these things. Ah, and would rename the page to |
@magicmatatjahu I think it's a very good idea. And I agree with @fmvilas that maybe the best place to put it is on the footer. |
@magicmatatjahu @mcturco yeah, I agree w/ Fran's idea. I think we should have a hyperlink in the footer for Brand or Brand Guidelines and then the URL to be |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Still needed. |
@magicmatatjahu I actually have an open PR here to add brand guidelines docs to the Do we think that the brand guidelines pages on the website are still needed if we have them in github? Or maybe we can just grab the content from the github pages and add them to the website as well? |
@mcturco Hi! I see you've done a lot of work on the given PR :D We can do it like this, the |
@magicmatatjahu yeah, that sounds good to me! |
Ok, so this issue will be still relevant. |
I believe this issue is resolved as per #808 😄 |
Reason/Context
Wondering if someone can help me duplicate the docs layout to a new page of the website perhaps with the slug
/brand-guidelines/
. I can then build out the pages that we need for this new area in MDX. Just unsure of how everything is included in the index and would rather the help of someone who knows what they are doing 😄Thanks in advance!
The text was updated successfully, but these errors were encountered: