Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gossip + Memberlist sync #1997

Open
rogeralsing opened this issue May 12, 2023 · 1 comment
Open

Gossip + Memberlist sync #1997

rogeralsing opened this issue May 12, 2023 · 1 comment

Comments

@rogeralsing
Copy link
Contributor

In some cases, e.g. using SeedNodeProvider, we might be too eager to start sending gossip requests.
e.g.
Node A tells Node C that Node B exists
Node C, now has node B in its memberlist, and immediately starts sending gossip

This is fine, but node C and node B might not yet have established a remote connection. and the gossip might timeout due to this.

not a major issue, but results in needless excessive logging

@rogeralsing
Copy link
Contributor Author

Various solutions could be interesting here.
e.g. memberlist could know how long it has known about other members. and gossip could be told to not gossip to nodes that are younger than x seconds.

or memberlist could have knowledge on the remote status of each member. e.g. know if we are connected to this node yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant