Tic Tac Toe Game

[tejinder-sharma]

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel.

@atapas first needs to authorize it.

[tejinder-sharma]

Please see and review the Game.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-play	✅ Ready (Inspect)	Visit Preview	May 24, 2022 at 2:02AM (UTC)

[atapas]

Thanks @tejinder-sharma for putting this play!

I have posted some review comments. Please check and let us know when the changes are done.

Here is the check list you can go through as well: https://github.com/atapas/react-play/wiki/ReactPlay-Code-Review-Checklist

Additionally, Please update the description of the PR.

Thanks!

[Programming-School-Pro-Coding]

Please align the text in header using flex-box:

display: flex;
align-items: center;
justify-content: center;

[tejinder-sharma]

Thank You for reviewing the header too.

[tejinder-sharma]

Hello Tapas and team,

I have made the appropriate changes but I am finding difficulty i.e

1. When a player won corresponding three squares are not getting the same color using functional components.
2. The console is showing a Component Unmount warning, I will work on that.

It is very helpful if you suggest what we can do on the first point.

[Programming-School-Pro-Coding]

Hello Tapas and team,

I have made the appropriate changes but I am finding difficulty i.e

1. When a player won corresponding three squares are not getting the same color using functional components.
2. The console is showing a Component Unmount warning, I will work on that.

It is very helpful if you suggest what we can do on the first point.

Ok, Very Amazing Work

[tejinder-sharma]

Hello Team,

I have resolved the above two issues. Now the game is perfectly working with no errors/warnings.

Please review the code.

[Programming-School-Pro-Coding]

Hello Team,

I have resolved the above two issues. Now the game is perfectly working with no errors/warnings.

Please review the code.

Please resolve conflicts

[atapas]

Hello Team,

I have resolved the above two issues. Now the game is perfectly working with no errors/warnings.

Please review the code.

@tejinder-sharma Could you please mark the comments as resolved(for the ones the review comments have been taken care). We will start a review once you resolved the comments as in it will help to identify what's taken care of and what's pending.

Also, kindly resolve the merge conflicts:

[tejinder-sharma]

Tapas and Team I have resolved the conflicts.

[tejinder-sharma]

I have resolved the mentioned issues.

[Programming-School-Pro-Coding]

LGTM

[atapas]

LGTM

[atapas]

Hi @tejinder-sharma are you still making code changes?

[tejinder-sharma]

Now everything is completed from my side. just one thing I forgot that was destructuring now it is completed.

Now, No more changes from my side.

[atapas]

@all-contributors please add @tejinder-sharma for Code

[allcontributors]

@atapas

I've put up a pull request to add @tejinder-sharma! 🎉

[atapas]

@tejinder-sharma Thanks for your contribution. Please do not stop with one. Keep contributing and make the project and community stronger. Thanks!

Don't forget to let the world know about your contributions!!!

[tejinder-sharma]

Wow, Thank you Tapas and Team, Your support from the start is like a teacher who told his student what to improve or what not to be. I have learned a lot. With this confidence, I will contribute more and more.🙌