Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a database url will always add to database list even when invalid #2183

Open
kinekt4 opened this issue May 6, 2022 · 1 comment
Open

Comments

@kinekt4
Copy link

kinekt4 commented May 6, 2022

Problem
This issue is related to #2178.
A fix (#2180) was made which added an alert box when an error was encountered.
However, the invalid database was added to the database list anyway.
I believe this should not be the case.

Screenshots/Demo
Database list after invalid url was added: https://imgur.com/KxqyLJ1

Athens Version

@cortex3
Copy link

cortex3 commented Oct 25, 2022

additionally I think it would improve the user experience if athens could accept full URLs with http://.
This was what I initially tried too and was confused that it didn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants