Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for deserializing and printing std::backtrace::Backtrace #35

Closed
yaahc opened this issue Apr 29, 2020 · 3 comments
Closed

add support for deserializing and printing std::backtrace::Backtrace #35

yaahc opened this issue Apr 29, 2020 · 3 comments

Comments

@yaahc
Copy link
Contributor

yaahc commented Apr 29, 2020

The nightly std::backtrace::Backtrace has a debug format that is relatively easy to parse. There are plans to eventually add a frame iterator api to backtrace similar to backtrace-rs's Backtrace but it seems rather far off. Until then I think it makes sense to write a deserializer for the Debug format of backtrace, which should hopefully be pretty stable, and use that to build the Frame objects used internally to print the backtrace.

@bjorn3
Copy link

bjorn3 commented Apr 29, 2020

which should hopefully be pretty stable

Debug implementations are not stable. Don't parse it! rust-lang/rust#59076 caused a lot of test breakage, because people depended on the exact debug formatting of structs in pretty print mode.

cc rust-lang/rust#62794.

@ArekPiekarz
Copy link

It looks like it's a duplicate of #24. But it means that more people care about solving this problem.

@yaahc
Copy link
Contributor Author

yaahc commented Apr 29, 2020

aah, fair enough, ill close this and add my comments to the other issue.

@yaahc yaahc closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants