Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single page nested Form support #2032

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Add single page nested Form support #2032

wants to merge 4 commits into from

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 29, 2023

Thank to #2031 we can test cross request changes reliably.

This PR should fix #1375 and #1860 (TODO review before merge) and related atk4/data#881 and atk4/data#1004.

The Form/Crud components for child records work on virtualized database which produces serialized state managed by the main Form and thus no changes are done on the real database until the main Form is submit.

TODO cover (or delete) https://app.codecov.io/gh/atk4/ui/commit/04aba5baff5a8f00747aaa851d34ed49ce3e3995/blob/src/Form/Control/Multiline.php#L430

might need fomantic/Fomantic-UI#2792, fomantic/Fomantic-UI#2944

@mvorisek mvorisek added the MAJOR label Apr 29, 2023
@mvorisek mvorisek force-pushed the crud_in_form branch 11 times, most recently from 70eb924 to 196e4e8 Compare May 9, 2023 19:13
@mvorisek mvorisek force-pushed the crud_in_form branch 16 times, most recently from 05a4b64 to f8b0fb5 Compare May 18, 2023 11:16
@mvorisek mvorisek force-pushed the crud_in_form branch 2 times, most recently from 877921b to f4ae384 Compare May 21, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 1:N Form Control
1 participant