Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some servant's battle voices are not correct #28

Open
squaresmile opened this issue Jun 28, 2022 · 10 comments
Open

Some servant's battle voices are not correct #28

squaresmile opened this issue Jun 28, 2022 · 10 comments
Labels
help wanted Extra attention is needed

Comments

@squaresmile
Copy link
Member

Some servant's battle voices are not correct:

  • Mash: NP (Awakening)
  • Artoria (Alter): NP 1 , 2
  • Gilgamesh: NP 1 , 2
  • Nero(Bride): NP 1, 2
  • Iskandar: NP 1, 2
  • Tawara Tota: Extra Attack 2 (missisng 2nd voice)
  • Minamoto-no-Raikou: NP1, 2, 3
  • Ishtar: NP1, 2
  • Medusa (Lancer): NP
  • Jaguar Warrior: NP
  • Merlin: NP1, 2
  • Miyamoto Musashi: NP1, 2, 3
  • First Hassan: NP
  • Arthur: NP
  • Hijikata: NP1 ,2
  • Orion, Chacha, Nero(Caster): whole thing
@squaresmile squaresmile added the help wanted Extra attention is needed label Jun 28, 2022
@ArtichaTM
Copy link

Katou "Black Kite" Danzo: NP 1

@ArtichaTM
Copy link

Mash lost her "Lord Camelot!" in NP audio

@ArtichaTM
Copy link

ArtichaTM commented Apr 12, 2024

Anne Bonny & Mary Read has broken Command Card 1/2/3 and Noble Phantasm Card 1, that for some reason duplicated with different subtitles + unplayable/undownloadable

@IVoyagerII
Copy link
Contributor

King Hassan Extra attack 3 line (updated earlier today) doesn't play on Atlas and doesn't appear in the explorer

@ArtichaTM
Copy link

ArtichaTM commented Apr 13, 2024

Found what's broken in Nero (Caster). Take a look into Ushiwakamaru
Psychedelic Wandering Tales costume (index 11)

Ushiwakamaru json

image

voicesLines[0]["id"] starts with 11, like any other audio assets. Before "_" u can find ascension (id of ascension or costume). And I relied on this a lot. However for some weird reason Nero (Caster) having id 0, while actually it's a voice line of costume!

Nero (Caster) json

image

Not all voice_lines bugged like that. Only:

{name} ({ascension}) points to one path {acension}\{category}\{overwrite before "-"}\{overwrite after"-"}
About the Event (Second Block) 1 (0) points to one path Asc0\EventReward\The Return of Nero Fest\Autumn 2019 1
Prize Roulette Voice 6 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 17
About the Event (Second Block) 5 (0) points to one path Asc0\EventReward\The Return of Nero Fest\Autumn 2019 5
About the Event (Second Block) 4 (0) points to one path Asc0\EventReward\The Return of Nero Fest\Autumn 2019 4
About the Event (Second Block) 3 (0) points to one path Asc0\EventReward\The Return of Nero Fest\Autumn 2019 3
Prize Roulette Voice 9 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 19
Prize Roulette Voice 12 (0)          points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 22
Shop Voice (Second Block) 2 (0)      points to one path Asc0\EventShop\The Return of Nero Fest\Autumn 2019 8
Prize Roulette Voice 2 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 13
Prize Roulette Voice 10 (0)          points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 20
Shop Voice (Second Block) 5 (0)      points to one path Asc0\EventShop\The Return of Nero Fest\Autumn 2019 11
Prize Roulette Voice 5 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 16
Shop Voice (Second Block) 4 (0)      points to one path Asc0\EventShop\The Return of Nero Fest\Autumn 2019 10
About the Event (Second Block) 6 (0) points to one path Asc0\EventReward\The Return of Nero Fest\Autumn 2019 6
Shop Voice (Second Block) 1 (0)      points to one path Asc0\EventShop\The Return of Nero Fest\Autumn 2019 7
Shop Voice (Second Block) 3 (0)      points to one path Asc0\EventShop\The Return of Nero Fest\Autumn 2019 9
Prize Roulette Voice 11 (0)          points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 21
Prize Roulette Voice 4 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 15
Shop Voice (Second Block) 11 (0)     points to one path Asc0\EventShop\The Return of Nero Fest\Autumn 2019 12
About the Event (Second Block) 2 (0) points to one path Asc0\EventReward\The Return of Nero Fest\Autumn 2019 2
Prize Roulette Voice 3 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 14
Prize Roulette Voice 8 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 18

@ArtichaTM
Copy link

ArtichaTM commented Apr 13, 2024

Ishtar has 2 voice lines for default summon and one as Event Reward. For some reason, default voice lines have same type in parent dictionary and in voice line dict, but for event reward svtVoiceType = "firstGet"

Correct type

image

Wrong type

image

@ArtichaTM
Copy link

Nitocris (Assassin). What is this? Ascension 1-4. Undownloadable, only names left

Screenshot

image

@ArtichaTM
Copy link

ArtichaTM commented Apr 14, 2024

Ivan the Terrible has NP lines in Battle (while usually they in "Treasure Device" section)

@ArtichaTM
Copy link

ArtichaTM commented Apr 19, 2024

Super Bunyan has broken voice line in absolutely new voice line category. Unplayable, undownloadable, untranslated

Image

image

Mary Anning has broken voice line in new voice line category. Unplayable, undownloadable, without translation

Image

image

@squaresmile
Copy link
Member Author

I added a lot of the missing audio files so it should be much more complete now. However some lines are not complete on the db/api.

https://apps.atlasacademy.io/db/NA/servant/142/voices
Ishtar NP lines are missing An Gal Ta Ki Gal Šè and またの名を Jabal Hamrin Breaker
The game has them somehow
They are in https://static.atlasacademy.io/NA/Audio/NoblePhantasm_202000/NP_202000_1.mp3
and https://static.atlasacademy.io/NA/Audio/NoblePhantasm_202000/NP_202000_8.mp3
but dunno how to find them in master data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants