React 19 support: Migrate away from defaultProps
#2580
+20
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hooray! All contributors have signed the CLA. |
1 task
|
Thank you for taking the time ! |
|
Hello everyone. Will this change be accepted? We are using this package and we will eventually have to replace it with something else if this is not updated. We happy with how this one works, so we would prefer to continue using it. |
zlasa
approved these changes
Jun 26, 2024
|
got the same error saying defaultProps will be removed from memo components on my NextJS 14 project, looking forward to this merged soon! Thanks team for the hardwork! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Love the library ❤️
This PR migrates away from using
defaultPropsinconnected-droppableand moves the default prop logic intodroppableitself. This is because React 19 is removing support fordefaultPropsin functional components.I've seen the maintenance notice in the repo and totally understand if you don't want to go forward with merging/releasing this. But I thought I'd raise it anyway since the scope of the changes is quite small and without it the library will no longer work for projects using React 19 without a custom npm/yarn patch applied on top.
Fixes #2563
Fixes #2576