Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

use rimraf #276

Closed
wants to merge 1 commit into from
Closed

use rimraf #276

wants to merge 1 commit into from

Conversation

UziTech
Copy link

@UziTech UziTech commented Oct 1, 2019

Identify the Bug

Doesn't install on window

fixes #275

Description of the Change

use rimraf instead of rm -rf

Possible Drawbacks

none

Verification Process

installed on windows

Release Notes

Fix windows install

@Gert-dev
Copy link

Gert-dev commented Oct 3, 2019

This makes me curious, do other language clients work on Windows at all? It seems highly unlikely that we're the first to encounter this error as there have been many language clients for much longer.

php-ide-serenata has only just switched and Windows users now immediately encounter this error.

@UziTech
Copy link
Author

UziTech commented Oct 3, 2019

It also seems fairly strange that tests pass on appveyor

@Gert-dev
Copy link

Gert-dev commented Oct 3, 2019

Hmm, I think I see what the problem is (#166), it is because Serenata is using an unstable version of the atom-languageclient - intentionally, I might add, since I need the targeted commit to fix an issue with autocompletion.

It is likely it'll be solved by targeting a stable release, but autocompletion will be bugged for users. If a new stable release is performed here, that would likely also fix the problem (but this fix might as well).

@UziTech
Copy link
Author

UziTech commented Oct 27, 2019

@Aerijo @50Wliu @damieng @atom Any feedback?

@damieng
Copy link
Contributor

damieng commented Oct 27, 2019

I left GitHub in the first quarter of 2018 and haven't touched anything Atom related since the end of 2018 when they officially killed Atom IDE off, sorry.

@UziTech UziTech closed this Jan 10, 2020
@UziTech UziTech reopened this Jan 10, 2020
@UziTech
Copy link
Author

UziTech commented Jan 10, 2020

@atom Could we get this merged so it works on windows and a new release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't install on windows
3 participants