Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Probable bug in \\z anchor matching #76

Closed
lierdakil opened this issue Sep 5, 2016 · 1 comment
Closed

Probable bug in \\z anchor matching #76

lierdakil opened this issue Sep 5, 2016 · 1 comment
Labels

Comments

@lierdakil
Copy link

So, I've been looking over the source code, and I don't think that \\z anchor, defined at https://github.com/atom/first-mate/blob/master/src/pattern.coffee#L71 will ever match.

First of, shouldn't backslashes be escaped, i.e. '$(?!\\n)(?<!\\n)'?

Second, since at https://github.com/atom/first-mate/blob/master/src/rule.coffee#L56 newline is appended to all lines, this will never match, will it?

@winstliu winstliu added the bug label Sep 5, 2016
@lierdakil
Copy link
Author

This apparently was fixed with #100. At least a quick test shows that \z anchor now matches end of document correctly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants