Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Handle string quotes in JSX #174

Open
1 task done
edemaine opened this issue Feb 21, 2021 · 1 comment
Open
1 task done

Handle string quotes in JSX #174

edemaine opened this issue Feb 21, 2021 · 1 comment

Comments

@edemaine
Copy link

Prerequisites

Description

String quotes should not be processed when inside JSX (HTML) blocks.

Steps to Reproduce

  1. Create a file test.coffee

  2. Type the following file content:

    <code>
      Hello world's
      this is some {'text'}
    </code>

Expected behavior:

This is the highlighting I expect, which is what I get when using JavaScript highlighting (.jsx extension):

image

Actual behavior:

This is the highlighting I get:

image

Reproduces how often:

100%

Versions

1.54.0 x64 on Windows 10

I originally observed this issue in vscode (see microsoft/vscode#117143).

Additional Information

I'm new to these JSON syntax files, but given that it works in JavaScript, I imagine it is possible (and hopefully easy?) to fix.

Related issue: #135. But I think that should be closed, because #172 merged.

@edemaine
Copy link
Author

I just noticed https://github.com/crisward/cjsx which might be an approach to solving this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant