Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Not ignoring ERB tags in quoted string #32

Open
Tracked by #1
ismyrnow opened this issue Sep 3, 2015 · 3 comments
Open
Tracked by #1

Not ignoring ERB tags in quoted string #32

ismyrnow opened this issue Sep 3, 2015 · 3 comments

Comments

@ismyrnow
Copy link

ismyrnow commented Sep 3, 2015

I have a quoted string which should contain <% in it. The result is that the string isn't closed unless a closing ERB tag and closing quote is found.

I'm not sure how you would work around this in the grammar without breaking the ERB highlighting. However, I would consider proper YAML highlight a priority, considering the context.

Example:

password: "foo<%bar"
now: highlighting no longer works
close: %>"
now: highlighting works

Currently, this also breaks in Github. However, I'll include a screenshot just in case:

2015-09-03_1113

@ismyrnow
Copy link
Author

ismyrnow commented Sep 3, 2015

To reduce things even further, all you need to do is close the original quoted string on a new line:

password: "foo<%bar"
now: highlighting no longer works
close: "
now: highlighting works

The behavior on Github differs here, though.

@winstliu winstliu added the bug label Sep 4, 2015
@kimroen
Copy link

kimroen commented Oct 6, 2016

In my case, I wanted an interpolated string surrounded by < and >, so something like this:

user_line: "%{name} <%{email}>"
user_description: "This line has no syntax highlighting"

@winstliu
Copy link
Contributor

winstliu commented Jan 9, 2017

Blocked on atom/first-mate#83.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants