Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

appveyor does not trigger tagged build for prerelease tag #212

Closed
shiftkey opened this issue Jul 30, 2019 · 2 comments · Fixed by #221
Closed

appveyor does not trigger tagged build for prerelease tag #212

shiftkey opened this issue Jul 30, 2019 · 2 comments · Fixed by #221

Comments

@shiftkey
Copy link
Contributor

https://ci.appveyor.com/project/Atom/node-keytar/builds/26352122

Nothing obvious from the logs what happened, and I don't have admin rights to investigate whether a webhook failed to be delivered.
@jakobvogel jakobvogel mentioned this issue Jul 31, 2019
Merged
@shiftkey shiftkey mentioned this issue Aug 18, 2019
Closed
@shiftkey
Copy link
Contributor Author

Because of this omission #216 showed that users of the library can see weird MSBuild-related errors

@shiftkey
Copy link
Contributor Author

The problem here is the regex defined in appveyor.yml

node-keytar/appveyor.yml

Lines 13 to 15 in 3704289

branches:
only:
- /master|^v\d+\.\d+\.\d+$/

Is more strict than what is used for Travis:

node-keytar/.travis.yml

Lines 18 to 21 in 3704289

branches:
only:
- master
- /^v\d+\.\d+(\.\d+)?(-\S*)?$/

@shiftkey shiftkey changed the title appveyor did not build prerelease tag appveyor does not trigger tagged build for prerelease tag Sep 10, 2019
@shiftkey shiftkey mentioned this issue Sep 10, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

relax regex to detect prerelease tag on appveyor atom/node-keytar
1 participant
@shiftkey