Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Locks folders (cannot rename/delete) on Windows #101

Closed
andreialecu opened this issue Feb 4, 2016 · 4 comments
Closed

Locks folders (cannot rename/delete) on Windows #101

andreialecu opened this issue Feb 4, 2016 · 4 comments

Comments

@andreialecu
Copy link

I believe this module may cause the problems in:
atom/atom#3365

It appears that libuv has fixed this a while ago:
nodejs/node#375

I think this means that recursive fs.watch that does not lock any folder should now be available in node core.

Can this module be fixed? Alternatively, could it be replaced with something like chokidar instead?

What does this module do that others don't?

@kumarharsh
Copy link

I get this error while deleting:

Error: EBUSY: resource busy or locked, rmdir 'D:\src\app\shared\components\<MyFolder>'
    at Error (native)

@hartalex
Copy link

hartalex commented Oct 4, 2016

It appears that the call to ReadDirectoryChangesW is locking the monitored directory. This is a quirk of Windows. Because PathWatcher.watch isn't recursive, each sub directory that is also monitored will also be locked. I think a solution would be to implement a recursive version of PathWatcher.watch. This way only the top level directory will be locked and all of the sub directories will no longer be locked.

@rsese
Copy link

rsese commented Sep 14, 2018

@andreialecu - we have a new file watcher system that's not enabled by default but is available at Settings > File System Watcher if you set it to Experimental filesystem watching library. Can you give this setting a try on the latest versions of Atom, and let us know if you still the same behavior?

@rsese
Copy link

rsese commented Sep 14, 2018

ahh sorry - was just chatting with another maintainer and see that using the new file watcher setting won't help with atom/atom#3365 because the tree view would also need to be updated to use the new file watcher system.

Since the team will use atom/atom#3365 to track the issue, we're going to go ahead and close this in favor of atom/atom#3365.

@rsese rsese closed this as completed Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants