Skip to content
This repository has been archived by the owner on Sep 7, 2018. It is now read-only.

TypeScript colon does not show up properly #44

Closed
ryanolsonx opened this issue Dec 13, 2017 · 3 comments
Closed

TypeScript colon does not show up properly #44

ryanolsonx opened this issue Dec 13, 2017 · 3 comments
Milestone

Comments

@ryanolsonx
Copy link

Prerequisites

Description

Opening a file in the typescript language with One Light Syntax Theme renders colon characters as a block of black.

Steps to Reproduce

  1. Open atom
  2. Open a typescript file that contains an object literal with a colon
  3. You should see the black block in your syntax

Expected behavior: colon to show up nicely

Actual behavior: You see colon as a black block

Reproduces how often: 100%

Versions

You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

Atom : 1.23.0
Electron: 1.6.15
Chrome : 56.0.2924.87
Node : 7.4.0

Windows 10 OS

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

CSS

It looks as though the selector for the colon (in TypeScript) is .syntax--meta.syntax--separator. If I toggle off the background-color attribute, the issue goes away (I just don't want to keep this in my stylesheet forever -- especially needing to comment it out when I change themes).

Current

.syntax--meta.syntax--separator {
    background-color: #373b41;
    color: #383a42;
}

With Fix

.syntax--meta.syntax--separator {
    color: #383a42;
}

I would send a pull request, but I don't want to break any other highlights that this selector is addressing.

Screenshot

image

@winstliu
Copy link

Fixed in #41, should already be available in Atom 1.24 beta.

@ryanolsonx
Copy link
Author

Thanks!

@morhook
Copy link

morhook commented Feb 18, 2018

Thanks a lot! Fixed problem for me too!

@simurai simurai added this to the 1.24 milestone Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants