Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite label, width, or sas.format in xportr_type() #85

Merged
merged 6 commits into from
Apr 20, 2023

Commits on Apr 13, 2023

  1. Update xportr_type() to retain column attributes

    Fixes issue #75 by retaining column attributes (such as label). Tested
    with `xportr_label()` only, not with `metacore::set_variable_labels()`
    (is that even a real function?)
    EeethB committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    db83fcb View commit details
    Browse the repository at this point in the history
  2. Add test for label vs type order

    Now that `xportr_type()` is not overwriting column labels, applying it
    before or after `xportr_label()` should make no difference
    EeethB committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    338c475 View commit details
    Browse the repository at this point in the history
  3. Update xportr_type() to drop column attribute 'class' only

    In general, setting the type for each column should retain each column's
    attributes, such as label, width, and sas.format. These are set by other
    xportr functions. However, in cases where a column in the input dataset
    has a class already, such as a Date or a factor, this attribute should
    be dropped from the column. If it is not, it causes an error
    EeethB committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    1f91297 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7ff8652 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Update NEWS.md

    EeethB committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    22fb13e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d67cf2c View commit details
    Browse the repository at this point in the history