Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc 1.72.0: flooded with warning: lint const_err has been removed: converted into hard error #63

Closed
michalfita opened this issue Sep 14, 2023 · 5 comments
Labels
bug Something isn't working build system Related to build system or CI support

Comments

@michalfita
Copy link
Collaborator

   Compiling atsamv71q19b v0.25.0 (/home/manveru/Projects/atsamx7x-rust/pac/atsamv71q19b)
warning: lint `const_err` has been removed: converted into hard error, see issue #71800 <https://github.com/rust-lang/rust/issues/71800> for more information
 --> pac/atsams70n19b/src/lib.rs:3:9
  |
3 | #![deny(const_err)]
  |         ^^^^^^^^^
  |
  = note: `#[warn(renamed_and_removed_lints)]` on by default

So, it's materialization of rust-lang/rust#71800.

We need CI to actually test with MRV and latest.

@michalfita michalfita added bug Something isn't working build system Related to build system or CI support labels Sep 14, 2023
@tmplt
Copy link
Member

tmplt commented Sep 15, 2023

We need CI to actually test with MRV and latest.

This is a good idea. Minimum would be a required to pass, but any errors from latest could be emitted as warnings for review in PRs.

@michalfita
Copy link
Collaborator Author

any errors from latest could be emitted as warnings for review

Except GitHub contrary to GitLab cannot emit warning statues from builds. In general I find GitLab superior to GitHub, it's just much less popular choice for Rust's crates.

@tmplt
Copy link
Member

tmplt commented Sep 17, 2023

I must have conflated the two.

@martinmortsell
Copy link
Contributor

With the merge of #64 this issue is resolved, right?

@michalfita
Copy link
Collaborator Author

Yes, it is. We now need to move to PACs generated with newer svd2rust what I already exercised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build system Related to build system or CI support
Projects
None yet
Development

No branches or pull requests

3 participants