Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete expired keys cron job is not triggered #1350

Closed
srieteja opened this issue Jul 8, 2024 · 0 comments · Fixed by #1351
Closed

delete expired keys cron job is not triggered #1350

srieteja opened this issue Jul 8, 2024 · 0 comments · Fixed by #1351
Assignees
Labels
bug Something isn't working

Comments

@srieteja
Copy link
Contributor

srieteja commented Jul 8, 2024

Describe the bug

The client-side job to delete expired keys is not being triggered. Although, this is not an issue as the server still sends the commit entries for expired keys that need to be removed.
The issue being: logic to parse Duration() type input in AtClientPreferences into a Schedule() type object is faulty.

Steps to reproduce

  1. Create a new instance of AtClient
  2. Observe that the deleteExpiredKeys job does not run at 10min intervals, which it is scheduled to do.

Expected behavior

The cron job to remove expired keys should run at scheduled intervals and remove all expired keys.

Additional context

The logic introduced in '' relies on the constructor in Schedule(); which does not allow the cron job to run at scheduled intervals instead only at one specific time of day.
e.g. Schedule(minutes: 10, seconds: 30) would mean it would run at 00:10:30s everyday instead of running every 10min30s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant