Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error codes section of spec not up to date with error_message.dart in at_commons #7

Open
gkc opened this issue Feb 5, 2022 · 0 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@gkc
Copy link
Contributor

gkc commented Feb 5, 2022

Describe the bug
Error codes section of spec is not up to date with error_message.dart in at_commons.

  • Multiple error codes have been added to error_message.dart which are not included in this doc

To Reproduce
See https://github.com/atsign-foundation/at_protocol/blob/trunk/specification/at_protocol_specification.md and compare with https://github.com/atsign-foundation/at_tools/blob/trunk/at_commons/lib/src/exception/error_message.dart

Expected behavior
All error codes defined in error_message.dart should be documented here

Additional context
While adding new code to at_commons's error_message.dart, I did a GitHub/atsign-foundation search for any mention of standard AT codes (I searched for AT0015) and found that this document is not up to date. Also found this one in the atsign.dev repo which also needs to be fixed I guess, although it seems odd to have two copies of effectively the same doc... @nickelskevin what is the intended relationship between the spec in this repo and the spec in the atsign.dev repo? should one just be a clone of the other?

@gkc gkc added bug Something isn't working documentation Improvements or additions to documentation labels Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants