Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does .vscode directory need to be in this repo (or should it be .gitignore #311

Closed
cpswan opened this issue Aug 9, 2023 · 3 comments · Fixed by #314
Closed

Does .vscode directory need to be in this repo (or should it be .gitignore #311

cpswan opened this issue Aug 9, 2023 · 3 comments · Fixed by #314
Assignees
Labels
bug Something isn't working

Comments

@cpswan
Copy link
Member

cpswan commented Aug 9, 2023

Describe the bug

#285 introduced .vscode/launch.json but it probably shouldn't be here

Steps to reproduce

NA

Expected behavior

Less clutter

@cpswan cpswan added the bug Something isn't working label Aug 9, 2023
@XavierChanth
Copy link
Member

The launch.json is intended, it is generic and should work on any system using that system's preferred python installation.

@cpswan
Copy link
Member Author

cpswan commented Aug 9, 2023

@XavierChanth can we maybe add some commentary to it to explain why it's there then?

@XavierChanth
Copy link
Member

I don't see it as necessary, it's default launch.json config that vscode automatically creates for you. The name of the launch config as it appears in vscode is "Python: Current File" and it does exactly what you would expect, it runs the currently open python file.

CleanShot 2023-08-09 at 17 28 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants