Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron job eventually stops attempting to start daemon #379

Closed
JeremyTubongbanua opened this issue Aug 23, 2023 · 5 comments
Closed

Cron job eventually stops attempting to start daemon #379

JeremyTubongbanua opened this issue Aug 23, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@JeremyTubongbanua
Copy link
Member

JeremyTubongbanua commented Aug 23, 2023

Describe the bug

Cron job attempts to start daemon a couple of times then stops trying

Everything works with tmux, I've noticed.

Video of me reproducing it: https://drive.google.com/file/d/1MGnbwQyWfm8LEkFjvcq1rLXEqbi3x4M0/view?usp=sharing

Steps to reproduce

  1. On your device, run the SSHNPD installer script
  2. Since I don't have tmux, it will resort to cron and logrotate
  3. I tail -f ~/.sshnpd/logs/@jeremy_0.log
  4. it stops trying attempting to run sshnpd eventually, even when I provide it some keys

Expected behavior

Keep on attempting

Additional context

There was a while loop for checking if the sshnp device exists in #211 , but is not in the SSHNPD code anymore

@JeremyTubongbanua JeremyTubongbanua added the bug Something isn't working label Aug 23, 2023
@JeremyTubongbanua JeremyTubongbanua changed the title Cron job does not start daemon Cron job eventually stops attempting to start daemon Aug 23, 2023
@JeremyTubongbanua
Copy link
Member Author

JeremyTubongbanua commented Aug 23, 2023

I don't think the daemon should be started up on its own

When I install something like a video game, I don't expect it to open immediately.

@XavierChanth
Copy link
Member

XavierChanth commented Aug 23, 2023

I don't think the daemon should be started up on its own

When I install something like a video game, I don't expect it to open immediately.

Make a separate discussion ticket for this please.
Edit: made one here https://github.com/atsign-foundation/operations/issues/79

Can you check that nohup is available in your environment command -v nohup

@XavierChanth
Copy link
Member

XavierChanth commented Sep 1, 2023

@JeremyTubongbanua if this is in Docker then cron won't start the daemon at all because cron is not started when the container is started, and I use the reboot notation. This needs to be tested on an actual vm / device first

@JeremyTubongbanua
Copy link
Member Author

Putting this as P1 since this bug would mean the installation instructions don't work on Docker containers

@XavierChanth
Copy link
Member

They don't need to work on docker containers, but there was a missing check in the installer which might cause it to fail. The CRON solution requires both logrotate and nohup to be installed

@XavierChanth XavierChanth closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants