Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: pin npm to version 10.8.2 #1451

Merged
merged 4 commits into from
Oct 14, 2024
Merged

build: pin npm to version 10.8.2 #1451

merged 4 commits into from
Oct 14, 2024

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Oct 14, 2024

- What I did
build: pin npm to version 10.8.2 because of this which is caused by this

- How I did it
See commits

- How to verify it
Checks pass and dependabot checks pass

@gkc gkc requested a review from cpswan October 14, 2024 13:34
cpswan
cpswan previously approved these changes Oct 14, 2024
@gkc
Copy link
Contributor Author

gkc commented Oct 14, 2024

@cpswan Even though npm install will now fail with an ugly error unless you are running npm 10.8.2, the code scanner still pops it up as an issue. This feels like a code scanning tool issue to me? since I am now doing precisely what is recommended to package.json to ensure the specific version of npm is being used? However I've just pushed another commit as per this documentation which will ensure that package-lock.json is respected - it may be that that is the actual problem being flagged by the code scanning tool here.

@gkc gkc merged commit 2fdfe9e into trunk Oct 14, 2024
9 checks passed
@gkc gkc deleted the gkc-fix-deps branch October 14, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants