Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sshnpd updater patches #226

Merged
merged 3 commits into from
Jun 28, 2023
Merged

fix: sshnpd updater patches #226

merged 3 commits into from
Jun 28, 2023

Conversation

XavierChanth
Copy link
Member

- What I did

  • moved post_install function to run before restarting sshnpd
  • service restarter now restarts like so:
    killall -qu "$SSHNP_USER" -r "$BINARY_NAME$"
    which ensures that the restarter loop keeps running in the background

- How I did it

- How to verify it

- Description for the changelog
fix: sshnpd updater patches

@XavierChanth XavierChanth requested a review from cconstab June 28, 2023 17:46
@cconstab
Copy link
Member

cconstab commented Jun 28, 2023

I get an odd error on pi

spi0(183): Operation not permitted

running with bash -x

Installation complete!
+ '[' update = update ']'
+ restart_service
+ killall -qu pi -r 'sshnpd$'
spi0(183): Operation not permitted
pi@xmt-pi:~ $

should read

killall -q -u pi -r 'sshnpd$'

typo on line 262

Copy link
Member

@cconstab cconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on Pi works fine

@XavierChanth XavierChanth merged commit 21ba682 into trunk Jun 28, 2023
@XavierChanth XavierChanth deleted the xavier-patches-2 branch July 6, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants