Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: packages dir #232

Merged
merged 6 commits into from
Jul 3, 2023
Merged

refactor: packages dir #232

merged 6 commits into from
Jul 3, 2023

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Jun 30, 2023

- What I did

Moved all of sshnoports to the packages/sshnoports

- How I did it

- How to verify it

It might be easier to start by taking a look at the branch.

Test build in progress


N.B. : Upon merge of this PR, the following redirects need updating:

getsshnpd.noports.com -> https://raw.githubusercontent.com/atsign-foundation/sshnoports/trunk/packages/sshnoports/scripts/install_sshnpd

getsshnp.noports.com -> https://raw.githubusercontent.com/atsign-foundation/sshnoports/trunk/packages/sshnoports/scripts/install_sshnp

(Both entries need packages/sshnoports added to their paths)

- Description for the changelog
refactor: packages dir

@XavierChanth
Copy link
Member Author

XavierChanth commented Jun 30, 2023

I messed up a few items in the diff... package-macos-arm64.sh and the README.md were not considered renames... but all of the main package was considered renames :)

@cconstab
Copy link
Member

I am still not sure about a noports repo...

We have other noports apps in standal9ne repos..

Lorawan demo

AtTalk

Others coming ...

For some reaso. I thought this was more about keeping the Python version away from the Dart version ..

@gkc / @XavierChanth / @cpswan

Your call

@gkc
Copy link
Contributor

gkc commented Jul 1, 2023

@XavierChanth shoukd we merge #233 first?

@XavierChanth
Copy link
Member Author

@XavierChanth shoukd we merge #233 first?

Yes, I've merged. Will address the merge conflicts

@XavierChanth XavierChanth requested a review from gkc July 1, 2023 23:21
@XavierChanth
Copy link
Member Author

Once this is merged, other branches will need to merge trunk into their branches

Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkc
Copy link
Contributor

gkc commented Jul 3, 2023

@XavierChanth who can update the redirects for getsshnpd.noports.com and getsshnp.noports.com?

@XavierChanth XavierChanth merged commit 8772d28 into trunk Jul 3, 2023
@XavierChanth
Copy link
Member Author

Merged, and redirect has been updated

@XavierChanth XavierChanth deleted the refactor/packages-dir branch July 6, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants