Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cease using internet_connection_checker #298

Merged
merged 8 commits into from
Aug 1, 2023

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Aug 1, 2023

Closes #292 . This PR will complete one of the tasks identified in #292 ; the other two tasks are completed by the changes in this at_client PR which have now been released in version 3.0.64 of the at_client package

- What I did
feat: cease using internet_connection_checker

- How I did it

  • use latest version of at_client, v3.0.64, which eliminates all usage within the at_client package itself of the internet_connection_checker package
  • removed usage of internet_connection_checker package by removing usage of at_client's now-deprecated ConnectivityListener
  • replaced with a simple periodic heartbeat check

- How to verify it

  • automated tests pass
  • run sshnpd; take down your connection to internet; should see a message connection lost within at most 25 seconds; bring the internet connection back up; should see a message connection available within 15-20 seconds

- Description for the changelog
feat: cease using internet_connection_checker

@gkc gkc marked this pull request as ready for review August 1, 2023 17:28
@gkc gkc requested a review from cconstab August 1, 2023 17:28
Copy link
Member

@cconstab cconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might in the future want to add an option to set the polling value from 15-120 seconds. Beyond 120 second the TCP stack will kick in and drop things.

Or even to switch this off to save bandwidth...

@gkc gkc merged commit 5a08f46 into trunk Aug 1, 2023
@gkc gkc deleted the gkc-remove-connectivity-listene-usage branch August 1, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of Internet connection checker more configurable
2 participants