chore: use comma for list delimiter in sshnp config #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Changed the delimiter for lists in the config file from ; to , so that the spec is both valid .bash and .env.
Since we haven't done a release including this feature yet, it should still be okay to implement this design change.
I also removed "list-devices" parameter from toArgs and subsequently toConfig and toFile of SSHNPParams, this parameter is not meant to be part of the main args and should not be written to the config files. (A bug curtly and I found today which was appending "=false" to the end of the config files produced using SSHNPParams.toFile()
- How I did it
- How to verify it
- Description for the changelog
chore: use comma for list delimiter in sshnp config