refactor: refactor sshnpd_impl.dart for future feature velocity #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'` into their own methods
… readability (imo)
…xtract everything after parsing the parameters from the notification payload into its own method `startReverseSsh` which we can reuse
- tidy up `_handleLegacySshRequestNotification` - rename `localPort` to `remoteForwardPort` for clarity - make parameters ints where they should be ints - have various functions make their parameters required named instead of positional
…made in every notification handling method which takes an AtNotification as a parameter
…` rather than `managerAtsign` since in future we will likely have multiple atSigns which are authorized to make requests
…N payload via notification with key `ssh_request.$device.sshnp`) for an ssh session, and handle requests for reverse ssh (which is all we've supported up until now)
JeremyTubongbanua
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
@device:ssh_request.$device.sshnp@requester- How I did it
Easiest to see by looking at the individual commits, which show the refactoring progressing step by step
- How to verify it
Tests pass (no change to current behaviour)