Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-up info is huge in 4.4 with Qt 6 #1435

Closed
sashaaaaaaaaa opened this issue Jul 22, 2024 · 14 comments
Closed

Pop-up info is huge in 4.4 with Qt 6 #1435

sashaaaaaaaaa opened this issue Jul 22, 2024 · 14 comments
Labels
Bug Something isn't working
Milestone

Comments

@sashaaaaaaaaa
Copy link

Describe the bug
Pop-up track information looks fine in 4.3.1 but is oversized in 4.4

Steps to reproduce
Just mouse over a track.

Expected behavior
Should be normal sized

Additional information

  • Audacious version and interface (Qt / GTK / Winamp)
    4.4 (Qt and Winamp)

  • Operating system and version
    Arch Linux

  • Desktop environment
    KDE Plasma 6.1.3

  • Screenshots

Audacious 4.3.1:
Screenshot_20240722_074521

Audacious 4.4:
Screenshot_20240722_074605

@sashaaaaaaaaa sashaaaaaaaaa added the Bug Something isn't working label Jul 22, 2024
@radioactiveman
Copy link
Member

I can't reproduce this issue. There are also no related code changes between 4.3 and 4.4 for the info popup.

Are you familiar with building packages? Could you then please rebuild audacious and audacious-plugins with Qt 5 support?
To do that, add the Meson option -Dqt5=true in the PKGBUILD build() function.

@jlindgren90: Can you reproduce this?

@jlindgren90
Copy link
Member

I have not seen this.

@sashaaaaaaaaa
Copy link
Author

I built it with Qt 5 and yeah it looks fine there. I also wanna say I tried with the default plasma theme already.

@radioactiveman radioactiveman changed the title Pop-up info is huge in 4.4 Pop-up info is huge in 4.4 with Qt 6 Jul 24, 2024
@radioactiveman
Copy link
Member

Good to know, thanks. Adjusted the title accordingly. Is the pop-up also huge if the track has no album cover?

@mschwendt
Copy link

Qt 6 alone cannot be blamed, since the pop-ups are normal here with a Qt 6 build of Audacious. Not using KDE Plasma, though, but GNOME Shell.

@radioactiveman
Copy link
Member

Today I have tried to reproduce this with Audacious 4.4 and the latest version of KDE Neon. It uses Plasma 6.1.3 and Qt 6.7.2. The size of the pop-up is as expected, I can't reproduce your issue. Neither with/without album cover, X11/Wayland, different scaling factors.

Is the pop-up also huge if the track has no album cover?

Please reply @sashaaaaaaaaa.

@sashaaaaaaaaa
Copy link
Author

I've managed to trace down the issue to my two monitors being stacked vertically. If in the monitor config I move my secondary monitor to the side instead or even below my main monitor, the issue goes away. Totally bizarre. Btw this is on X11 and the main monitor is 1080p and the secondary is 1440x900.

And yeah it happens if the track has no album cover too.

@radioactiveman
Copy link
Member

@jlindgren90: Do you have multiple monitors and can reproduce the issue with a vertical setup? I have only one and can't help here.

@jlindgren90
Copy link
Member

I normally use a horizontal 2-3 monitor setup and haven't seen this. I am not going to be able to look into it more at the moment, sorry.

@TheThing
Copy link

TheThing commented Oct 5, 2024

Glad I'm not the only one having this issue
mynd

@mschwendt
Copy link

mschwendt commented Oct 5, 2024

@TheThing So, what details can you tell about your runtime environment?

@radioactiveman
Copy link
Member

Fixed with 19e6b64.

By using my TV as secondary monitor I could finally reproduce this with Qt 6, even with a standard horizontal monitor setup.

@TheThing
Copy link

TheThing commented Oct 9, 2024

My notifications are broken so I never saw your reply asking for details on the runtime environment.
But really glad you got it fixed. Once I have some free time I'll verify it by installing the git version and see if the problem is gone for good :)

@sashaaaaaaaaa
Copy link
Author

Yeah I tried the latest commit and it's all good now 👍

@radioactiveman radioactiveman added this to the 4.4.2 milestone Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants