Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Make Scheme.[dtype|labels] a property #279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: Make Scheme.[dtype|labels] a property #279

wants to merge 1 commit into from

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Aug 5, 2022

Closes #63.

But I'm not sure if this really is a good idea.

@frankenjoe
Copy link
Collaborator

frankenjoe commented Jan 18, 2023 •
edited
Loading

The problem is that with the current logic dtype and labels are no longer stored to YAML when you make them private attributes and introduce a property instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make schemes safe against user changes
2 participants
@hagenw @frankenjoe