Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFT tracking #11

Open
ThorstenBux opened this issue Jan 30, 2020 · 7 comments
Open

Add NFT tracking #11

ThorstenBux opened this issue Jan 30, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request javascript related to javascript code NFT all about NFT markers

Comments

@ThorstenBux
Copy link
Contributor

@kalwalt
Where are we with this?

@kalwalt
Copy link
Contributor

kalwalt commented Jan 30, 2020

@ThorstenBux it is partially implemented. Actually you can select the Pinball marker but it can't be loaded because parse a wrong path: it parse the patt.hiro path plus the .fset extension and so fails to load.

@kalwalt
Copy link
Contributor

kalwalt commented Feb 2, 2020

Pr #17 testing the NFT feature.

@kalwalt kalwalt added enhancement New feature or request javascript related to javascript code NFT all about NFT markers labels Feb 2, 2020
@kalwalt
Copy link
Contributor

kalwalt commented Feb 4, 2020

With the PR #17 we added support for NFT markers. For now we can only load the Pinball marker, and without the WebWorker. This will implemented in another Pull Request.

@kalwalt
Copy link
Contributor

kalwalt commented Apr 3, 2020

@ThorstenBux May i add the webWorker or is better to implement other features before? Like loading of patterns (NFT, Pattern...) ? I would also test, during these days, if the Test and Publish feature works or not...

@ThorstenBux
Copy link
Contributor Author

Yes, sure go for it. :). Get the webWorker in that is important.
Regarding uploads of NFT I was thinking if we can use zipped versions then we could just upload one

@kalwalt
Copy link
Contributor

kalwalt commented Apr 5, 2020

Yes, sure go for it. :). Get the webWorker in that is important.

Ok I will start to work on this feature. I colud also try to embedd the WebWorker inside the Component with a Blob object like did recently for Ar.js. But probably better to start with a simpler approach for now.

Regarding uploads of NFT I was thinking if we can use zipped versions then we could just upload one

In this case we should skip the problem of the format?

@kalwalt
Copy link
Contributor

kalwalt commented Apr 16, 2020

Trying to add a WebWorker with this PR #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript related to javascript code NFT all about NFT markers
Projects
None yet
Development

No branches or pull requests

2 participants