Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corners drawn on top of the dash-to-panel panel #8

Open
amivaleo opened this issue May 5, 2022 · 9 comments
Open

Corners drawn on top of the dash-to-panel panel #8

amivaleo opened this issue May 5, 2022 · 9 comments

Comments

@amivaleo
Copy link

amivaleo commented May 5, 2022

Hi!

I use dash-to-panel extension.
Yours draws the rounded corners on top of the panel drawn by dash-to-panel.

Take a look:
Screenshot from 2022-05-05 12-02-58

Can you consider working on this? Thank you! :)

@amivaleo
Copy link
Author

So... :3

@Commenter25
Copy link

Still an issue :/

@aunetx
Copy link
Owner

aunetx commented Aug 6, 2022

I'm sorry, I'm really out of time (and of motivation...) right now, but when I have my computer with me I will try to see what is wrong :)

@Commenter25
Copy link

Hey, don't apologize, it's perfectly understandable! Don't feel bad for not having the time and motivation to work on libre software projects. I've been there, and the feeling hurts. But don't force yourself, and if anyone comes after you, don't let them bring you down. Your mental health comes first <3

@aunetx
Copy link
Owner

aunetx commented Aug 19, 2022

Hello again, could you just explain me this issue more? What exactly is wrong with the extension?

To be honest, it does not work for me either with dash to panel -- but it is because the corners are drawn on top of dtp, but simply that they are not drawn at all. So I just need to know what may be wrong to correct it if possible

@amivaleo
Copy link
Author

Hi.
The corners are drawn actually, but they are black just like the panel, that's why you might have not seen them.

This is why I put a screenshot here, of the top-right corner. There I drawn the panel in red in dtp. As you can see, the black corner is drawn on top of the panel.

@aunetx
Copy link
Owner

aunetx commented Aug 19, 2022

Do you have the screen corners option activated in my extension's preferences? Because it looks like it is this, if I'm not mistaken

@amivaleo
Copy link
Author

I think I have, yes.
But I can't confirm now. I'm on vacation. I'll tell you when I get back at the end of this month. 💪

@Commenter25
Copy link

Commenter25 commented Aug 20, 2022

Looking deeper into this and thinking more critically about it, I believe the screen corners function is working as intended. The problem is actually the panel corners function, which does not consider DTP as a panel. In the following screenshots, I've configured screen corners to red, and panel corners to blue.

It looks like screen corners are drawn on all 4 corners, ignoring the panel entirely. The corners below the panel are drawn separately, attached to the panel itself. This is probably how it should continue working.
Screenshot from 2022-08-20 15-16-46-min

When DTP is enabled, the panel corners simply disappear. They are not hidden behind the screen corners, they are simply not there. I believe this is because DTP has hidden the original GNOME panel entirely, and because the panel corners are attached to that panel, they are hidden as well.
Screenshot from 2022-08-20 15-16-57-min
Screenshot from 2022-08-20 15-17-05-min

The fix may simply be to detect if DTP is enabled, and attach to it instead. However, I'm unfamiliar with how all of the related code works, so this might be more complex to implement properly than I think. Also, panel position, panel size, and auto-hide may all be factors. And these can all vary for each monitor. It may be worth allowing panel corners to be disabled per-monitor as well. I have a stationary full-width panel on the bottom of one monitor, and an autohiding 92% wide one on the left of the other. I would want corners on the first panel, but having corners on the second would be weird. (then again, so is my panel layout (and my monitor layout (and me))

2022-08-20_15-19-20-min

Also, to be clear, I made sure I was using the new update before trying all of this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants