From 5da53558d7e94982db459d0ba02894d6baec7025 Mon Sep 17 00:00:00 2001 From: Chunpeng Huo Date: Fri, 3 Apr 2020 16:29:08 +1100 Subject: [PATCH] feat: switch from libsass to dart-sass Because dart-sass is now the reference implementation of sass. --- lib/dependencies.json | 4 ++-- .../cli-bundler/aurelia_project/tasks/process-css.ext | 8 ++++---- skeleton/cli-bundler/package.json | 2 +- skeleton/webpack/package.json | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/dependencies.json b/lib/dependencies.json index 7d3e2ad37..720230523 100644 --- a/lib/dependencies.json +++ b/lib/dependencies.json @@ -51,7 +51,7 @@ "gulp-postcss": "^8.0.0", "gulp-protractor": "^4.1.1", "gulp-rename": "^2.0.0", - "gulp-sass": "^4.0.2", + "gulp-dart-sass": "^1.0.0", "gulp-sourcemaps": "^2.6.5", "gulp-stylus": "^2.7.0", "gulp-tslint": "^8.1.4", @@ -80,13 +80,13 @@ "less": "^3.11.1", "less-loader": "^5.0.0", "minimatch": "^3.0.4", - "node-sass": "^4.13.1", "postcss-loader": "^3.0.0", "postcss-url": "^8.0.0", "promise-polyfill": "^8.1.3", "protractor": "^5.4.3", "regenerator-runtime": "^0.13.3", "requirejs": "^2.3.6", + "sass": "^1.26.3", "sass-loader": "^8.0.2", "style-loader": "^1.1.3", "stylus": "^0.54.7", diff --git a/skeleton/cli-bundler/aurelia_project/tasks/process-css.ext b/skeleton/cli-bundler/aurelia_project/tasks/process-css.ext index 191519c19..80934f2c0 100644 --- a/skeleton/cli-bundler/aurelia_project/tasks/process-css.ext +++ b/skeleton/cli-bundler/aurelia_project/tasks/process-css.ext @@ -10,7 +10,7 @@ import notify from 'gulp-notify'; import less from 'gulp-less'; // @endif // @if feat.sass -import sass from 'gulp-sass'; +import sass from 'gulp-dart-sass'; // @endif // @if feat.stylus import stylus from 'gulp-stylus'; @@ -35,7 +35,7 @@ import * as notify from 'gulp-notify'; import * as less from 'gulp-less'; // @endif // @if feat.sass -import * as sass from 'gulp-sass'; +import * as sass from 'gulp-dart-sass'; // @endif // @if feat.stylus import * as stylus from 'gulp-stylus'; @@ -59,7 +59,7 @@ export default function processCSS() { .pipe(less()) // @endif // @if feat.sass - .pipe(sass().on('error', sass.logError)) + .pipe(sass.sync().on('error', sass.logError)) // @endif // @if feat.stylus .pipe(stylus()) @@ -90,7 +90,7 @@ export function pluginCSS(dest) { .pipe(less()) // @endif // @if feat.sass - .pipe(sass().on('error', sass.logError)) + .pipe(sass.sync().on('error', sass.logError)) // @endif // @if feat.stylus .pipe(stylus()) diff --git a/skeleton/cli-bundler/package.json b/skeleton/cli-bundler/package.json index 00780b783..c2b3a9147 100644 --- a/skeleton/cli-bundler/package.json +++ b/skeleton/cli-bundler/package.json @@ -48,7 +48,7 @@ // @endif // @if feat.sass - "gulp-sass": "", + "gulp-dart-sass": "", // @endif // @if feat.stylus diff --git a/skeleton/webpack/package.json b/skeleton/webpack/package.json index c5c55f5f9..da19bf73f 100644 --- a/skeleton/webpack/package.json +++ b/skeleton/webpack/package.json @@ -41,7 +41,7 @@ // @if feat.sass "sass-loader": "", - "node-sass": "", + "sass": "", // @endif // @if feat.stylus