Skip to content

Commit

Permalink
fix(webpack): use webpack4 hook that replaced deprecated plugin api
Browse files Browse the repository at this point in the history
Thanks @oising for the fix. @jods4 recommended using a meaningful tap name.

closes #923
  • Loading branch information
3cp committed Oct 14, 2018
1 parent 9ebe10a commit 8b5d732
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/resources/tasks/build-webpack.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function buildWebpack(done) {
compiler.watch({}, onBuild);
} else {
compiler.run(onBuild);
compiler.plugin('done', () => done());
compiler.hooks.done.tap('AureliaCLI', done);
}
}

Expand Down
2 changes: 1 addition & 1 deletion lib/resources/tasks/build-webpack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function buildWebpack(done) {
compiler.watch({}, onBuild);
} else {
compiler.run(onBuild);
compiler.plugin('done', () => done());
compiler.hooks.done.tap('AureliaCLI', done);
}
}

Expand Down

0 comments on commit 8b5d732

Please sign in to comment.