Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary Bluebird config in main.[js|ts]? #534

Closed
trydis opened this issue Mar 10, 2017 · 2 comments · Fixed by #536
Closed

Unnecessary Bluebird config in main.[js|ts]? #534

trydis opened this issue Mar 10, 2017 · 2 comments · Fixed by #536

Comments

@trydis
Copy link
Contributor

trydis commented Mar 10, 2017

I'm submitting a bug report

  • Library Version:
    0.26.1

Please tell us about your environment:

  • Operating System:
    Windows 10

  • Node Version:
    v7.2.0

  • NPM Version:
    4.1.2
  • Browser:
    N/A

  • Language:
    all

Current behavior:
In #505 Bluebird config was moved to prepended file.

The upgrade notes say:

We have removed the code for configuring Bluebird from main.[js|ts]

When i create a new project using the CLI, it still contains the config in main.[js|ts], as well as prepending it.

Expected/desired behavior:

  • What is the expected behavior?
    I expected main.[js|ts] to not contain the config.

  • What is the motivation / use case for changing the behavior?
    If my understanding is correct, the config in main.[js|ts] is unnecessary. If not, just close this.

@fabioluz
Copy link
Contributor

fabioluz commented Mar 10, 2017

It seems that @AshleyGrant forgot to remove bluebird configuration from the .ts file.

1 day in the dungeon with no food for him 😄

@trydis Could make a PR to correct this? What you'd have to do is the same as #505 but for typescript. I could do this but I'm going to lunch now.

@AshleyGrant
Copy link
Contributor

Aww maaannnnn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants