fix(importer): support nodejs module default main file "index.js" when "main" is missing in package.json #842
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n "main" is missing in package.json When "main" is missing in package.json, nodejs uses default main file "index.js", it will complain when default main file is missing. This fix supports nodejs module with missing "main" in package.json. It solves importing issue on nodejs module "date-fns". #831 is related, that PR solves tracing issue on "date-fns".
|
This fix also means amodro strategy will import absolutely any nodejs module. There would not be any nodejs module in the field with missing default main file, because those malfunctioned modules would not reach your ears. Whether we can trace what we imported, that is another problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "main" is missing in package.json, nodejs uses
default main file "index.js", it will complain when
default main file is missing.
This fix supports nodejs module with missing "main"
in package.json. It solves importing issue on nodejs
module "date-fns". #831 is related, that PR solves
tracing issue on "date-fns".