Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that transaction.output is a valid address #132

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

spilin
Copy link
Collaborator

@spilin spilin commented Nov 30, 2021

When transaction.output is not a valid address do not use it as contractAddress.

@spilin spilin requested a review from 0x3bfc as a code owner November 30, 2021 10:51
@spilin spilin requested a review from artob November 30, 2021 10:52
@antonpaisov antonpaisov self-requested a review November 30, 2021 16:27
@artob artob self-assigned this Dec 1, 2021
Copy link
Contributor

@artob artob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs instructions to reload the affected stored procedure added to the changelog.

@artob artob assigned spilin and unassigned artob Dec 1, 2021
@artob artob added the bug Something isn't working label Dec 1, 2021
@artob artob changed the title Validate that transaction.output is a valid address Validate that transaction.output is a valid address Dec 1, 2021
@antonpaisov antonpaisov self-requested a review December 1, 2021 11:50
Copy link
Contributor

@artob artob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artob artob merged commit 4d20d11 into master Dec 1, 2021
@artob artob deleted the output_violates_address_check branch December 1, 2021 15:12
Copy link

@Sanmyohtet9 Sanmyohtet9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

®

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_getTransactionReceipt failing for old contract creation transactions with unexpected output
4 participants