Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package-lock.json and yarn.lock #216

Open
TimDaub opened this issue Jun 5, 2019 · 3 comments
Open

Add package-lock.json and yarn.lock #216

TimDaub opened this issue Jun 5, 2019 · 3 comments
Labels
Milestone

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Jun 5, 2019

Scope

  • burner-wallet and potentially other components like dapparatus currently do not include package-lock.json or yarn.lock
  • These files are supposed to be committed however as they provide integrity when installing dependencies

Deliverables

  • Add yarn.lock and package-lock.json in all components used by the burner-wallet.

Roles

bounty gardener: @TimDaub / 15%
bounty worker: name / 75%
bounty reviewer: name / 15%

@TimDaub TimDaub added this to the Sprint 1 milestone Jun 5, 2019
@johannbarbie
Copy link
Collaborator

johannbarbie commented Jun 13, 2019

by pedro:
You shouldnt include both lock files
You should use one or the other
Otherwise you dont have integrity between people developing with yarn and npm
Unless you include a pre-push script to update both for consistency
And even then they wouldnt always result the same

@dmihal
Copy link
Collaborator

dmihal commented Jun 13, 2019

Agreed, in todays call we seemed to agree to use Yarn and yarn.lock.

@NetizenAbel
Copy link

The npm package-lock.json should never be committed; the yarn.lock is meant to be. If you use yarn; it's best to alter the package.json to include a requirement for it. Either both must go, or make the good call to hop on to Yarn all the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants