Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrypt dependency fails on node v12.12.0 #252

Open
jooray opened this issue Dec 1, 2019 · 0 comments
Open

scrypt dependency fails on node v12.12.0 #252

jooray opened this issue Dec 1, 2019 · 0 comments

Comments

@jooray
Copy link

jooray commented Dec 1, 2019

When running npm install on node v12.12.0 macos, the install fails due to requiring deprecated scrypt package.

3670 verbose stack Error: scrypt@6.0.3 install: `node-gyp rebuild`
3670 verbose stack Exit status 1
3670 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:332:16)
3670 verbose stack     at EventEmitter.emit (events.js:210:5)
3670 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
3670 verbose stack     at ChildProcess.emit (events.js:210:5)
3670 verbose stack     at maybeClose (internal/child_process.js:1021:16)
3670 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)
3671 verbose pkgid scrypt@6.0.3
3672 verbose cwd /Users/juraj/paralelnapolis/burner-wallet
3673 verbose Darwin 19.0.0
3674 verbose argv "/usr/local/Cellar/node/12.12.0/bin/node" "/usr/local/bin/npm" "uninstall" "scrypt"
3675 verbose node v12.12.0
3676 verbose npm  v6.13.1
3677 error code ELIFECYCLE
3678 error errno 1
3679 error scrypt@6.0.3 install: `node-gyp rebuild`
3679 error Exit status 1
3680 error Failed at the scrypt@6.0.3 install script.
3680 error This is probably not a problem with npm. There is likely additional logging output above.
3681 verbose exit [ 1, true ]

It is a known issue:
barrysteyn/node-scrypt#192

It will not be fixed upstream, because the package is no longer maintained:

If you are using scrypt.hash, it is now available natively in the Node.js crypto module.

If you are using scrypt.kdf / scrypt.verifyKdf, scrypt-kdf is a close-to-direct replacement.

We need to get rid of the dependency in order for burner wallet to work on recent systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant