Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State Handler with Custom Session Store #233

Closed
datasage opened this issue Mar 13, 2018 · 5 comments
Closed

State Handler with Custom Session Store #233

datasage opened this issue Mar 13, 2018 · 5 comments
Assignees
Milestone

Comments

@datasage
Copy link

datasage commented Mar 13, 2018

Currently the state handler will initialize a new session store when first created. Even if a custom session store is provided.

If a custom session store is used, it should be either able to be passed into the SessionStateHandler class or automatically used when instantiating the class.

SessionStateHandler could instead allow anything that implements StoreInterface, instead of just SessionStore.

@jspetrak
Copy link
Contributor

jspetrak commented Mar 13, 2018

@datasage How is that possible? Looking into the constructor code:

if (isset($config['state_handler'])) {
    if ($config['state_handler'] === false) {
        $this->stateHandler = new DummyStateHandler();
    } else {
        $this->stateHandler = $config['state_handler'];
    }
} else {
    $this->stateHandler = new SessionStateHandler(new SessionStore());
}

when state_handler parameter is passed to Auth0, that should take it as is.

@datasage
Copy link
Author

datasage commented Mar 13, 2018 via email

@joshcanhelp joshcanhelp self-assigned this Mar 13, 2018
@joshcanhelp
Copy link
Contributor

@datasage - Good find, thank you! If you can put through a PR (dev as the base), that would be great. Otherwise, I'll handle it before the next patch release coming up.

@joshcanhelp
Copy link
Contributor

Adding in 5.1.1, PR coming now

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants