Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Guzzle 7 #421

Closed
Nyholm opened this issue Jan 30, 2020 · 4 comments
Closed

Support Guzzle 7 #421

Nyholm opened this issue Jan 30, 2020 · 4 comments

Comments

@Nyholm
Copy link
Contributor

Nyholm commented Jan 30, 2020

We are soon about to release Guzzle 7. I see that this library reverted changes in version 6 alfa and went back to hard dependency on Guzzle.

Im would recommend to support PSR-18 instead of a concrete implementation. That would avoid dependency issues with Guzzle versions.
Btw, Guzzle 7 will support PSR-18.

@joshcanhelp
Copy link
Contributor

@Nyholm - I like the idea of improving interoperability, for sure. The HTTPPlug library had the main documented methods marked deprecated and it looked like the next version would not be PHP 7.1 compatible. That's understandable but we weren't able to bump the PHP version higher than that for this major.

Would it be possible to do that and remain PHP 7.1 compat?

@Nyholm
Copy link
Contributor Author

Nyholm commented Feb 4, 2020

Of course. Httplug did a “technical” BC break to be able to use return types as required by prs18.
Both of them require php 7.0.
See https://packagist.org/packages/psr/http-client

About httplug v2: https://medium.com/php-fig/the-http-client-psr-9c2535132980

@jimmyjames
Copy link
Contributor

jimmyjames commented Aug 27, 2020

Fixed with #443

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants