Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind all methods of Auth0VueClient to this #110

Merged
merged 4 commits into from
May 2, 2022
Merged

Bind all methods of Auth0VueClient to this #110

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4204b7d
Bind all methods of Auth0VueClient to this
frederikprijck Apr 21, 2022
ef9ad7c
revert change
frederikprijck Apr 21, 2022
19f3301
Merge branch 'main' into fix/bind-this
frederikprijck Apr 26, 2022
9753a0a
Rework binding plugin methods
frederikprijck Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,24 @@ export class Auth0Plugin implements Auth0VueClient {
constructor(
private clientOptions: Auth0VueClientOptions,
private pluginOptions?: Auth0PluginOptions
) {}
) {
const plugin = this;

// Vue Plugins can have issues when passing around the instance to `provide`
// Therefor we need to bind all methods correctly to `this`.
this.loginWithRedirect = this.loginWithRedirect.bind(plugin);
this.loginWithPopup = this.loginWithPopup.bind(plugin);
this.logout = this.logout.bind(plugin);
this.getAccessTokenSilently = this.getAccessTokenSilently.bind(plugin);
this.getAccessTokenWithPopup = this.getAccessTokenWithPopup.bind(plugin);
this.checkSession = this.checkSession.bind(plugin);
this.handleRedirectCallback = this.handleRedirectCallback.bind(plugin);
this.buildAuthorizeUrl = this.buildAuthorizeUrl.bind(plugin);
this.buildLogoutUrl = this.buildLogoutUrl.bind(plugin);
this.__checkSession = this.__checkSession.bind(plugin);
this.__refreshState = this.__refreshState.bind(plugin);
this.__proxy = this.__proxy.bind(plugin);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question, is there a dynamic way we can do this (e.g. find all functions that are direct members of this and bind it)? I can just see this being missed later; if we add new methods later we're likely to forget to add it to this list and run into issues when someone tries to use it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR to do it more dynamic.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

}

install(app: App) {
this._client = new Auth0Client({
Expand Down Expand Up @@ -148,7 +165,7 @@ export class Auth0Plugin implements Auth0VueClient {
}
}

async __refreshState() {
private async __refreshState() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this private as it shouldnt be public

this._isAuthenticated.value = await this._client.isAuthenticated();
this._user.value = await this._client.getUser();
this._idTokenClaims.value = await this._client.getIdTokenClaims();
Expand Down