Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen title behavior is misleading #1286

Closed
luisrudge opened this issue Mar 8, 2018 · 0 comments · Fixed by #1288
Closed

Screen title behavior is misleading #1286

luisrudge opened this issue Mar 8, 2018 · 0 comments · Fixed by #1288

Comments

@luisrudge
Copy link
Contributor

luisrudge commented Mar 8, 2018

Currently, we always use the languageDictionary.title entry for the first screen loaded (which can be changed with the initialScreen option). So, even though you set languageDictionary.forgotPasswordTitle, if you set initialScreen: forgotPassword, it will use languageDictionary.title as the string and not languageDictionary.forgotPasswordTitle. This becomes a particular hard issue to handle if you're trying to use Lock's internal i18n dictionary, since you'd have to override forgotPasswordTitle based on which language you're trying to load Lock with.

After some discussion, we agreed to have the behavior changed to:

Assuming we're in the forgot password screen, for example:

  • If you have a screen specific title (languageDictionary.forgotPassswordTitle), use that
  • Else use Lock's default dictionary entry for that screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant