Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react to 16.x #1722

Closed
6 tasks done
petrogad opened this issue Aug 30, 2019 · 2 comments
Closed
6 tasks done

Upgrade react to 16.x #1722

petrogad opened this issue Aug 30, 2019 · 2 comments

Comments

@petrogad
Copy link

Description

Please upgrade React in package.json to support version 16.x. Right now projects using 16.x that also use auth0's lock have two instances of react in their bundle to satisfy lock0's implementation.

This is mentioned in #1564 #1067 however each of these issues have been closed. Can we maintain an open issue until the resolution of react being upgraded to 16?

Thank you!

Prerequisites

@luisrudge
Copy link
Contributor

I understand your frustration, but we can't migrate to react 16 without releasing a new major version and, currently, there's no ETA for a new major version. There's more context here: #1142 (comment)

In the meantime, you can use yarn resolutions to pin react@16 to your project. This will prevent two react copies from being bundled with your application. Here's an example: https://github.com/luisrudge/lock-react16/blob/master/package.json#L17-L19

We're leaving GH issues for actual bugs, that's why we're keeping issues like this one closed.

@stevehobbsdev
Copy link
Contributor

👋🏻 We now have a v12 beta version that includes an upgrade to React 18 - please see this issue and let us know what you think, or if you encounter any problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants