-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove lodash #879
remove lodash #879
Conversation
Reverting to per module packages as it was before ecdf6cc could do the same without reimplementing the wheel |
I think it is pure garbage to use lodash at all. And the only reason I "reinvented" the wheel was because lodash garbage was used in the first place and there could be some maniac using Number-classes and it would be backwards breaking to not use that isNumber functionality. The same with once and isPlainObject. It is only for backwards compatibility. |
I'm not found of lodash neither but it has the advantage of being tested and used by many, contrary to your implementations. As the goal is to reduce final package sise (not getting rid of lodash) importing individual methods will accomplish the same without maintenance burden nor testing on node-jsonwebtoken side but with the guarantee that those methods are well tested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies for the accidental approval.
There might be some hesitancy with this approach - so here's a lower impact alternative.
Closing due to inactivity |
Resolves #878
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
References
Testing
Checklist