Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lodash #879

Closed
wants to merge 2 commits into from
Closed

remove lodash #879

wants to merge 2 commits into from

Conversation

Uzlopak
Copy link

@Uzlopak Uzlopak commented Jan 12, 2023

Resolves #878

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.

If the UI is being changed, please provide screenshots.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@KuSh
Copy link

KuSh commented Feb 13, 2023

Reverting to per module packages as it was before ecdf6cc could do the same without reimplementing the wheel

@Uzlopak
Copy link
Author

Uzlopak commented Feb 14, 2023

I think it is pure garbage to use lodash at all. And the only reason I "reinvented" the wheel was because lodash garbage was used in the first place and there could be some maniac using Number-classes and it would be backwards breaking to not use that isNumber functionality. The same with once and isPlainObject. It is only for backwards compatibility.

@KuSh
Copy link

KuSh commented Feb 14, 2023

I think it is pure garbage to use lodash at all. And the only reason I "reinvented" the wheel was because lodash garbage was used in the first place and there could be some maniac using Number-classes and it would be backwards breaking to not use that isNumber functionality. The same with once and isPlainObject. It is only for backwards compatibility.

I'm not found of lodash neither but it has the advantage of being tested and used by many, contrary to your implementations. As the goal is to reduce final package sise (not getting rid of lodash) importing individual methods will accomplish the same without maintenance burden nor testing on node-jsonwebtoken side but with the guarantee that those methods are well tested

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the accidental approval.

There might be some hesitancy with this approach - so here's a lower impact alternative.

#889

@Uzlopak
Copy link
Author

Uzlopak commented Feb 22, 2023

Closing due to inactivity

@Uzlopak Uzlopak closed this Feb 22, 2023
@Uzlopak Uzlopak deleted the remove-lodash branch February 22, 2023 09:03
@ghost ghost mentioned this pull request Mar 8, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 9.0.0 Increased bundle size, probably due to lodash import
2 participants