Types conflict between jwks-rsa's @types/express-jwt@0 and express-jwt@7.5.0

[carboneater]

Describe the problem

Using express-jwt@7.5.0, with included types definitions, the types as linked by jwks-rsa@2.1.0 are ignored.

express-jwt@7 removed two types which are used in jwks-rsa@2's type definitions, thus leading to transpilation errors.

What was the expected behavior?

TS Code using express-jwt@7 & jwks-rsa@2 should transpile without errors

Reproduction

I did a small proof of concept for the transpilation issue, based on the example code for using multiple jwt providers.

• git clone https://github.com/carboneater/jwks-rsa-ts-poc.git
• npm ci
• npx tsc

node_modules/jwks-rsa/index.d.ts:1:10 - error TS2305: Module '"express-jwt"' has no exported member 'SecretCallback'.

1 import { SecretCallback, SecretCallbackLong } from 'express-jwt';
           ~~~~~~~~~~~~~~

node_modules/jwks-rsa/index.d.ts:1:26 - error TS2305: Module '"express-jwt"' has no exported member 'SecretCallbackLong'.

1 import { SecretCallback, SecretCallbackLong } from 'express-jwt';
                           ~~~~~~~~~~~~~~~~~~


Found 2 errors in the same file, starting at: node_modules/jwks-rsa/index.d.ts:1

Environment

• Version of this library used: 2.1.0
• Which framework are you using, if applicable: None in the PoC. Express usually
• Other modules/plugins/libraries that might be involved: express-jwt@7.5.2
• Any other relevant information you think would be useful:

[bombillazo]

Oh uh! Just updated express-jwt and here I am. 😞 Any workaround?

[bombillazo]

This package probably need supdating:

https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/express-jwt

[carboneater]

This package probably need supdating:

No,
Express-JWT@7 provides its own types, @types/express-jwt works as expected in stating it is now pointless to install and should be uninstalled.

As a matter of fact, the root cause of your issues is because the types are overriden by those provided by express-jwt.

[carboneater]

#301 should fix this one