-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android.content.ActivityNotFoundException: No Activity found to handle Intent #340
Comments
@ar-g I don't think this exception is for the SDK to handle. In the end, the custom tabs dependency will always fallback to a simple |
👍 That's a fair point, we can do this on the client-side. But since the library fires an intent I thought that would be more appropriate to do it on the library side. Regarding nowadays devices, we have the Stacktrace:
It only happens on limited set of devices, though, and only Android 9 and 7.1: |
I have same issue when using
I agree with @ar-g this should be handled on the library side, it's strange to do that on client side that you have to check whether an Android device has a browser which supports custom tab before opening an URL. |
@mrarronz How many devices do that % represent? Having a browser app installed is one of this library's requirements and there's nothing it can do when a browser app is missing. Yes, we can make that check internally, but you would still need to catch the error code that we raise and decide how you want to proceed. e.g. showing a dialog telling the user to install a browser app. To be clear, this library does not require a "Custom Tabs compatible" browser app installed. It will always default to any browser app that is available on the device. I'm tracking this feature request internally under |
@lbalmaceda This is the crash reported by Firebase in last 90 days, there are over a hundred of users affected by this. With over 10 versions released this issue still exists and even more for latest version. |
Thanks for the details. I've updated the labels to signal this is on our side now. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇♂️ |
I am facing the same error:
|
@IgorGanapolsky the fix for this is available in |
This issue is still happening when targeting |
This is an error from Chrome: GoogleChrome/android-browser-helper#89. |
Reproduce: Android 12 Google device, Or emulator.
|
We're getting quite a few exceptions on the Android side. I believe that the main cause is that we need to handle a case when the Browser app is not available on a specific Android device. So the solution would be to wrap this into the try-catch block and propagate the error to ReactNative and ask the user to download the Browser on the library consumer side. Another option is to check in advance if the browser is available https://developers.google.com/web/android/custom-tabs/implementation-guide#what_happens_if_the_user_doesn%E2%80%99t_have_a_browser_that_supports_custom_tabs_installed
Stacktrace:
I can create a PR for this to speed things up as this is causes a lot of issues for us.
The text was updated successfully, but these errors were encountered: