Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser tabs not closed upon webauth success/failure #87

Closed
mleduque opened this issue Aug 30, 2017 · 7 comments
Closed

Browser tabs not closed upon webauth success/failure #87

mleduque opened this issue Aug 30, 2017 · 7 comments
Labels
bug This points to a verified bug in the code
Milestone

Comments

@mleduque
Copy link

Each time I login, the WebAuth opens in a new browser tab.
After some roundtrip, I end up with a dozen login tabs in the browser.
How do I close the login tab in the browser ?

@mleduque
Copy link
Author

mleduque commented Sep 7, 2017

I this project dead ?

@cocojoe
Copy link
Member

cocojoe commented Sep 7, 2017

If you need help then please provide sufficient information, what steps are required to recreate this issue starting with
https://github.com/auth0-samples/auth0-react-native-sample/tree/master/00-Login

What platform/device are you testing with, what browser (presume this is Android) etc Let's see some screenshots or ideally a video.

Thanks

@cocojoe cocojoe added F0: more info needed bug This points to a verified bug in the code and removed F0: more info needed labels Sep 7, 2017
@cocojoe
Copy link
Member

cocojoe commented Sep 8, 2017

I've been testing and have noticed that browser tabs are not closed. Thanks

@cocojoe cocojoe changed the title Close the login page Browser tabs not closed upon webauth success/failure Sep 8, 2017
@lbalmaceda
Copy link
Contributor

lbalmaceda commented Sep 8, 2017

Adding the Intent.FLAG_ACTIVITY_NO_HISTORY to the intent here might help, although it doesn't guarantee that the tab is going to be closed later.

@mleduque
Copy link
Author

mleduque commented Sep 8, 2017

@cocojoe I'll add more information soon, thanks.
@lbalmaceda I will try, thanks.

@cocojoe
Copy link
Member

cocojoe commented Sep 8, 2017

@mleduque You can try PR #90 and feedback please.

@hzalaz hzalaz closed this as completed Sep 11, 2017
@hzalaz hzalaz added this to the v1.2.0 milestone Sep 11, 2017
@mleduque
Copy link
Author

After Updating the dependency to 1.2.0, I can confirm it doesn't happen anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code
Projects
None yet
Development

No branches or pull requests

4 participants