Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Autofac v6 #34

Closed
alistairjevans opened this issue Jul 26, 2020 · 3 comments · Fixed by #35
Closed

Compatibility with Autofac v6 #34

alistairjevans opened this issue Jul 26, 2020 · 3 comments · Fixed by #35

Comments

@alistairjevans
Copy link
Member

v6 Compatibility and version dependency checks ahead of release.

@alistairjevans
Copy link
Member Author

Since we took the CLS Compliant attribute out of the main Autofac package, I'm now getting CLS Compliance warnings throughout this integration.

Is this going to be an issue? Do we need to put the CLS Compliant flag back in Autofac?

@tillig
Copy link
Member

tillig commented Aug 28, 2020

Autofac isn't actually CLS compliant, I don't think. I forget what it was exactly that started failing.

I'd be OK with removing the CLS compliant flag from this integration if we can't put it back on core Autofac.

@alistairjevans
Copy link
Member Author

DiagnosticSource isn't CLS Compliant, hence Autofac can't be either; interestingly none of the .NET Core libraries are now, so it feels like CLS compliant is less useful nowadays anyhow.

@tillig tillig linked a pull request Sep 8, 2020 that will close this issue
@tillig tillig closed this as completed in #35 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants