Add mononym support

app/assets/javascripts/watchlist.js

@@ -373,7 +373,8 @@ function get_watchlist_function(){
           var id = _.get(watchlist_instance,'id');
           var course_id = _.get(watchlist_instance,'course_id');
           var user_id = _.get(watchlist_instance,'course_user_datum_id');
-          var user_name = _.get(data,`["users"][${user_id}].first_name`) + " " + _.get(data,`["users"][${user_id}].last_name`); 
+          // https://stackoverflow.com/questions/19902860/join-strings-with-a-delimiter-only-if-strings-are-not-null-or-empty
+          var user_name = [_.get(data,`["users"][${user_id}].first_name`), _.get(data,`["users"][${user_id}].last_name`)].filter(Boolean).join(' ');
           var user_email = _.get(data,`["users"][${user_id}].email`);
           var risk_condition_id = _.get(watchlist_instance,'risk_condition_id');
           var watchlist_status = _.get(watchlist_instance,'status');

app/controllers/assessment/grading.rb

@@ -293,11 +293,11 @@ def score_grader_info
     grader = (if score then score.grader else nil end)
     grader_info = ""
     if grader
-      grader_info = "#{grader.first_name} #{grader.last_name} (#{grader.email})"
+      grader_info = grader.full_name_with_email
     end
 
     feedback = score.feedback
-    response = {"grader" => grader_info, "feedback" => feedback, "score" => score.score}
+    response = { "grader" => grader_info, "feedback" => feedback, "score" => score.score }
     render json: response
   end
 

app/controllers/courses_controller.rb

@@ -258,7 +258,7 @@ def upload_roster
     if params[:doIt]
       begin
         save_uploaded_roster
-        flash[:success] = "Success!"
+        flash.now[:success] = "Successfully updated roster!"
       rescue StandardError => e
         if e != "Roster validation error"
           flash[:error] = e

app/controllers/scoreboards_controller.rb

@@ -51,7 +51,7 @@ def show
         @grades[uid] = {}
         @grades[uid][:nickname] = user.nickname
         @grades[uid][:andrewID] = user.email
-        @grades[uid][:fullName] = "#{user.first_name} #{user.last_name}"
+        @grades[uid][:fullName] = user.full_name
         @grades[uid][:problems] = {}
       end
       if @grades[uid][:version] != row["version"]

app/models/user.rb

@@ -17,7 +17,8 @@ class User < ApplicationRecord
   has_one :github_integration
 
   trim_field :school
-  validates :first_name, :last_name, :email, presence: true
+  validates :email, presence: true
+  validate :first_or_last_name
 
   # check if user is instructor in any course
   def instructor?
@@ -41,15 +42,15 @@ def instructor_of?(user)
   end
 
   def full_name
-    "#{first_name} #{last_name}"
+    [first_name, last_name].reject(&:empty?).join(' ')
   end
 
   def full_name_with_email
     "#{full_name} (#{email})"
   end
 
   def display_name
-    first_name && last_name ? full_name : email
+    first_name.present? && last_name.present? ? full_name : email
   end
 
   def after_create
@@ -261,4 +262,12 @@ def self.ldap_lookup(andrew_id)
 
     result
   end
+
+private
+
+  def first_or_last_name
+    return if first_name.present? || last_name.present?
+
+    errors.add(:base, "Student first name and last name can't both be blank")
+  end
 end

app/views/assessments/viewGradesheet.html.erb

@@ -46,7 +46,7 @@
       <% for s in @submissions do %>
           { "id": "",
             "name": {
-              name: "<%= s.course_user_datum.last_name %>, <%= s.course_user_datum.first_name %>",
+              name: "<%= [s.course_user_datum.last_name, s.course_user_datum.first_name].reject(&:blank?).join(', ') %>",
               email: "<%= s.course_user_datum.email %>"
             },
             "lec": "<%= s.course_user_datum.lecture %>",

app/views/course_user_data/index.html.erb

@@ -1,6 +1,6 @@
 <h3>Account Details for <%= @user.andrewID %></h3>
 <table class="noStyle" >
-<tr><td>Name</td><td><td> <%= @user.first_name %> <%= @user.last_name %> </td></tr>
+<tr><td>Name</td><td><td> <%= @user.full_name %> </td></tr>
 <tr><td class="noStyle" >First Name</td><td class="noStyle"><%= @user.first_name %></td></tr>
 <tr><td class="noStyle" >Last Name</td><td class="noStyle"><%= @user.last_name %></td></tr>
 <tr><td class="noStyle" >andrewID</td><td class="noStyle"><%= @user.andrewID %></td></tr>

app/views/course_user_data/show.html.erb

@@ -1,8 +1,8 @@
-<h2><%= @requestedUser.first_name %> <%= @requestedUser.last_name %> (<%= @requestedUser.nickname %>)</h2>
+<h2><%= @requestedUser.full_name %> (<%= @requestedUser.nickname %>)</h2>
 <ul class="gray-box">
   <li><b>Contact</b><br>
     <a href="mailto:<%= @requestedUser.email %>"><%= @requestedUser.email %></a></li>
-  <li> <b>About</b><br>
+  <li><b>About</b><br>
     Lecture <strong><%= @requestedUser.lecture %></strong><br>
     Section <strong><%= @requestedUser.section %></strong><br>
     Course <strong><%= @requestedUser.course.full_name %></strong><br>

app/views/course_user_data/user.html.erb

@@ -1,9 +1,9 @@
-<h2><%= @requestedUser.first_name %> <%= @requestedUser.last_name %> (<%= @requestedUser.nickname %>)</h2>
+<h2><%= @requestedUser.full_name %> (<%= @requestedUser.nickname %>)</h2>
 <ul class="gray-box">
   <li><b>Contact</b><br>
     <%= @requestedUser.andrewID %> (andrewid)<br>
     <a href="mailto:<%= @requestedUser.email %>"><%= @requestedUser.email %></a></li>
-  <li> <b>About</b><br>
+  <li><b>About</b><br>
     Lecture <strong><%= @requestedUser.lecture %></strong><br>
     Section <strong><%= @requestedUser.section %></strong><br>
     Course <strong><%= @requestedUser.course.display_name %></strong><br>

app/views/submissions/index.html.erb

@@ -99,7 +99,7 @@
           </label>
         </p>
       </td>
-      <td><%= "#{submission.course_user_datum.last_name}, #{submission.course_user_datum.first_name}" %>
+      <td><%= [submission.course_user_datum.last_name, submission.course_user_datum.first_name].reject(&:blank?).join(', ') %>
       <%= link_to submission.course_user_datum.email,
                       history_course_assessment_path(@course, @assessment, cud_id: submission.course_user_datum_id, partial: true),
                       {remote: true, class: :trigger}

app/views/users/show.html.erb

@@ -5,8 +5,18 @@
     <a href="mailto:<%= @user.email %>"><%= @user.email %></a>
   </li>
   <li> <b>About</b><br>
-    First name <strong><%= @user.first_name %></strong><br>
-    Last name <strong><%= @user.last_name %></strong><br>
+    <% if @user.first_name.present? %>
+      First name: <strong><%= @user.first_name %></strong>
+    <% else %>
+      First name: (student has no first name)
+    <% end %>
+    <br>
+    <% if @user.last_name.present? %>
+      Last name: <strong><%= @user.last_name %></strong>
+    <% else %>
+      Last name: (student has no last name)
+    <% end %>
+    <br>
     Courses 
     <% if @cuds.empty? %>
       <strong> None </strong>