Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize roster upload tables #1585

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Conversation

damianhxy
Copy link
Member

Description

  • Remove underscores from success table's table header (first_name, last_name, grading_policy)
  • Make error table's table header match that of the success table

Motivation and Context

Currently, the headers of the roster upload error table is different from the success table. Furthermore, the success table's table header contains unnecessary underscores. This PR remedies both issues by removing the underscores and standardizing the table headers.

How Has This Been Tested?

Before changes
Screen Shot 2022-09-12 at 10 45 20
Screen Shot 2022-09-12 at 10 45 29

After changes
Screen Shot 2022-09-12 at 10 52 55
Screen Shot 2022-09-12 at 10 52 34

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Copy link
Contributor

@michellexliu michellexliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damianhxy damianhxy merged commit 6a8b7d0 into master Sep 12, 2022
@damianhxy damianhxy deleted the standardize-roster-upload branch September 12, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants